Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drop point controller #671

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

brothercorvo
Copy link
Collaborator

No description provided.

@brothercorvo brothercorvo requested a review from naman108 March 4, 2024 16:22
@naman108
Copy link
Collaborator

This branch is an initial attempt to implement a component to manage the logic for drop point operations. This functionality would probably be a good candidate for testing the new OAS based component generator. @brothercorvo it would be useful if you could write up a brief description of it's expected functionality in this PR so we know what the purpose is.

@brothercorvo brothercorvo self-assigned this Mar 10, 2024
@brothercorvo
Copy link
Collaborator Author

Not sure that this is a separate component, probably a controller of the existing one

@naman108
Copy link
Collaborator

naman108 commented Mar 10, 2024

Not sure that this is a separate component, probably a controller of the existing one

maybe make this apart of the CoTManagerComponent? In any case we still need a clear idea of what it should do, I was thinking this may be related to issue #627. Maybe this component/controller could provide the crud functionalities for the API?

@brothercorvo
Copy link
Collaborator Author

CoTManager is what I WAS REFERRING TO.
we need also the COTManager to use the new blue print infrastructure and be able to save different types of CoT to persistency. this would solve #627

@naman108
Copy link
Collaborator

CoTManager is what I WAS REFERRING TO. we need also the COTManager to use the new blue print infrastructure and be able to save different types of CoT to persistency. this would solve #627

cool, then let's get #675 sorted out and then create a branch for this.

Copy link
Collaborator Author

@brothercorvo brothercorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the idea of this code is to evaluate a 'COT' aka Marker aka drop point and to react differently depending from the type and attitude, this is a crucial FTS functionality @naman108

@brothercorvo brothercorvo added the enhancement New feature or request label Apr 21, 2024
@brothercorvo brothercorvo added this to the 2.4 milestone Apr 21, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
33.3% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants